feat: add remoteFingerprints method to PeerConnection #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
commented
Jun 11, 2024
Returns a vector that contains the certificate fingerprints used by the connection to the remote peer. Closes paullouisageneau#1203 Refs paullouisageneau#1166
achingbrain
force-pushed
the
feat/add-remotefingerprints-method
branch
from
be5a4d9
to
9d03db6
Compare
This was referenced Jun 11, 2024
paullouisageneau
approved these changes
Jun 14, 2024
paullouisageneau
added a commit
that referenced
this pull request
Jun 14, 2024
paullouisageneau
added a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns a vector that contains the certificate fingerprints used by the connection to the remote peer.
Fingerprints are deduplicated before adding to the vector as the verifyFingerprint method can be invoked multiple times during the connection lifecycle.
Closes #1203
Refs #1166