Include payloadType in FrameInfo #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that consumers of onFrame can tell what codec the frame is in and know what decoder to use.
paullouisageneau
approved these changes
Apr 17, 2024
|
I'm only using it for audio right now, but I'm not sure why it would be different for video? It's still going to be RtpHeader + payload, no? Or is video packets totally different RtpHeader sizes etc? |
It's fundamentally different for video. Of course RTP headers are the same, but a single video frame may be packetized over several RTP packets, and the method to fragment and reconstruct a frame requires parsing payloads which is codec-dependent. |
edmonds
added a commit
to edmonds/vacon
that referenced
this pull request
Apr 21, 2024
edmonds
added a commit
to edmonds/libdatachannel
that referenced
this pull request
Oct 28, 2024
This follows the API change in paullouisageneau#1156 and is based on the very similar change to H264RtpDepacketizer (commit e9060bf).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that consumers of onFrame can tell what codec the frame is in and know what decoder to use.