Add PacingHandler #1153
Merged
Add PacingHandler #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sean-Der
force-pushed
the
pacing-handler
branch
5 times, most recently
from
cc8fc4f
to
c0be1f1
Compare
|
These are two screeshots showing the difference that pacing causes. Without it I see much higher peaks on outbound bandwidth |
Sean-Der
force-pushed
the
pacing-handler
branch
3 times, most recently
from
ffc534c
to
1d553f6
Compare
|
@paullouisageneau I have addressed everything in the review! Mind giving it a look, thank you |
Sean-Der
force-pushed
the
pacing-handler
branch
from
1d553f6
to
88a78ea
Compare
|
@paullouisageneau can I get another review please, thank you! |
MediaHandler that can be used to pace packet delivery Resolves paullouisageneau#1017 Co-authored-by: Paul-Louis Ageneau <[email protected]>
Sean-Der
force-pushed
the
pacing-handler
branch
from
8060914
to
56d8de0
Compare
|
@paullouisageneau Address everything, mind giving this a look! Fingers crossed :) |
|
@paullouisageneau Build failures I believe unrelated to the PR |
paullouisageneau
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaHandler that can be used to pace packet delivery