-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H264RtpDepacketizer: De-packetize access units rather than individual NALUs #1135
H264RtpDepacketizer: De-packetize access units rather than individual NALUs #1135
Conversation
@Sean-Der This should implement the change to the H264 de-packetizer you were asking for in #1134 (comment). I tested it with the Intel VPL encoder/decoder and packets produced with |
@paullouisageneau what do you think of this change? I am in big support of it! |
178e759
to
faad80c
Compare
I think this is great, the change totally makes sense. |
faad80c
to
27f238f
Compare
Re-based on master, made the start sequence configurable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thanks!
@edmonds Could you please address conflicts here too? |
@edmonds I would love to fix these merge conflicts for you! If you add me as a contributor to your fork I can fix them right now :) |
OK, just sent you an invite. |
27f238f
to
f085a25
Compare
… NALUs This commit updates the `H264RtpDepacketizer` to accumulate the NALUs for a particular RTP timestamp into a single output message, rather than returning each NALU as an individual message. This helps decoders which may want to see the non-VCL SPS/PPS/etc. NALUs in the same access unit as a VCL NALU rather than as standalone messages. Each NALU in the access unit buffer is prepended with an configurable H.264 start code
f085a25
to
f5acd35
Compare
@paullouisageneau done! can I get a review please? @edmonds I changed the name of the member variable from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, thank you.
This commit updates the
H264RtpDepacketizer
to accumulate the NALUs for a particular RTP timestamp into a single output message, rather than returning each NALU as an individual message. This helps decoders which may want to see the non-VCL SPS/PPS/etc. NALUs in the same access unit as a VCL NALU rather than as standalone messages.Each NALU in the access unit buffer is prepended with an H.264 Annex B start code 0x00, 0x00, 0x01.