Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the brms_seed to loo_R2 #1717

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

mcol
Copy link
Contributor

@mcol mcol commented Dec 12, 2024

This allows to fix the seed in loo_R2 and restore the RNG state when leaving the function. The implementation and the choice of the argument name follow what is already done in get_refmodel.brmsfit.

Fixes #1713.

@paul-buerkner
Copy link
Owner

Cool, thank you! Is there a reason you call the argument brms_seed rather than just seed?

@mcol
Copy link
Contributor Author

mcol commented Dec 17, 2024

Not particularly, I followed what was done in get_refmodel.brmsfit. I can change it simply to seed if you prefer.

@paul-buerkner
Copy link
Owner

paul-buerkner commented Dec 17, 2024 via email

@paul-buerkner
Copy link
Owner

Great, thank you! Merging now :-)

@paul-buerkner paul-buerkner merged commit 9d1acf2 into paul-buerkner:master Dec 17, 2024
0 of 5 checks passed
@mcol mcol deleted the issue_1713 branch December 18, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loo_R2: add seed argument
2 participants