Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cursor pointer #286

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hailuabk
Copy link

@hailuabk hailuabk commented May 20, 2019

When I typing the number in input, I got wrong cursor pointer position. I updated it.

Description

I updated cursor pointer in componentdidmount() function

Screenshots (if appropriate):

http://g.recordit.co/rVCKhYbNEo.gif

Types of changes

  • [ x ] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] All new and existing tests passed.

When I typing in input, I got wrong cursor pointer position. I fixed it.
@patw0929
Copy link
Owner

This pull request introduces 1 alert when merging 25f2f61 into 3f9b3c7 - view on LGTM.com

new alerts:

  • 1 for Unused or undefined state property

Comment posted by LGTM.com

1 for Unused or undefined state property
For Unused or undefined state property
@patw0929
Copy link
Owner

This pull request fixes 1 alert when merging 7273c52 into 3f9b3c7 - view on LGTM.com

fixed alerts:

  • 1 for Unused or undefined state property

Comment posted by LGTM.com

@patw0929
Copy link
Owner

This pull request fixes 1 alert when merging d7c6c37 into 3f9b3c7 - view on LGTM.com

fixed alerts:

  • 1 for Unused or undefined state property

Comment posted by LGTM.com

@patw0929
Copy link
Owner

This pull request fixes 1 alert when merging f91d7f0 into 3f9b3c7 - view on LGTM.com

fixed alerts:

  • 1 for Unused or undefined state property

Comment posted by LGTM.com

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 93.39% when pulling 53923c2 on hailuabk:update-cursor-pointer into 3f9b3c7 on patw0929:master.

@patw0929
Copy link
Owner

This pull request fixes 1 alert when merging 53923c2 into 3f9b3c7 - view on LGTM.com

fixed alerts:

  • 1 for Unused or undefined state property

Comment posted by LGTM.com

@ppprevost
Copy link

PLEASE MERGE ! it's a very good idea !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants