-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Wizard): use height token to set height #10332
Conversation
Preview: https://patternfly-react-pr-10332.surge.sh A11y report: https://patternfly-react-pr-10332-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like passing just a number works anymore, at least based on the basic Wizard example. We should probably update the height
prop type to just a string, and update any instance of it being used to pass a string/CSS unit value.
The Wizard height doesn't seem to be adjustable inside a modal still, either. @mcoker should React set the --#{$modal-box}--c-wizard--FlexBasis
token as well?
I can update the prop type to string (or fix it so numbers work). The core counterpart to this isn't merged yet, so it's not setting the flex-basis with the value atm. |
Pending further updates to patternfly/patternfly#6457, this PR will need to updated to use the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than updating/fixing the width prop type so numbers don't break, lgtm! Agree it should be good once this is updated with the latest core.
What: React counterpart to patternfly/patternfly#6457