Descriptionlist complex content demo #10237
Conversation
tlabaj
requested review from
andrew-ronaldson,
a team and
mattnolting
and removed request for
a team
There was a problem hiding this comment.
@ajaypratap003 this demo does not match any core demos and It is not needed.
tlabaj
removed request for
wise-king-sullyman,
kmcfaul,
andrew-ronaldson and
mattnolting
tlabaj
requested review from
a team,
tlabaj,
kmcfaul,
mattnolting and
mmenestr
and removed request for
a team
|
closing this PR as this demo does not match any core demos and It is not needed. |
|
Preview: https://patternfly-react-pr-10237.surge.sh A11y report: https://patternfly-react-pr-10237-a11y.surge.sh |
There was a problem hiding this comment.
Comment about imports below, but also some smaller updates needed to be closer to the core complex example
| section: components | ||
| --- | ||
|
|
||
| import BarsIcon from '@patternfly/react-icons/dist/esm/icons/bars-icon'; |
There was a problem hiding this comment.
The imports here just need to be cleaned up to remove things that aren't actually being used in this demo.
|
@tlabaj This PR was closed and reopened, do we still want to add this demo? |
|
If we were to keep this demo I'd want to click it back to design. The layout is a bit off in my mind. |
|
@andrew-ronaldson @kmcfaul core has a complex content example for Description list. Adding this demo was to achieve core parity. |
|
This PR has been automatically marked as stale because it has not had recent activity. |
|
@andrew-ronaldson should the core review be removed and we close this PR? |
What: Closes #10228
Descriptionlist complex content demo
Additional issues: