Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Skip to content - focus remains at top of page in demos #7554

Open
thatblindgeye opened this issue Jun 15, 2022 · 11 comments
Open

Bug - Skip to content - focus remains at top of page in demos #7554

thatblindgeye opened this issue Jun 15, 2022 · 11 comments
Assignees
Labels
Milestone

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Jun 15, 2022

Describe the problem
Followup based on comment #7520 (comment)

The skip to content component has a bug in demos where when you click it, focus remains at the top of the page/the page does not scroll to the main content.

How do you reproduce the problem?

  1. Go to skip to content React demo
  2. Press Tab to place focus on the Skip to content button, press Enter, then press Tab again. Notice that focus goes back to the skip button, and the page did not scroll to the main content.
    • If you click anywhere on the page first then follow the steps above, the page does scroll to the main content, but focus still remains at the top of the page when pressing Tab again
  3. Go to bulk select table demo and repeat Step 2, and notice the same behavior.

Expected behavior
The skip to content in React demos should have the same behavior as seen in the skip to content HTML demo

Additional notes

Possibly an issue with routing? Noticed when testing something via VO in Safari that the page does scroll to the linked content area, but then immediately returns to the top of the page.

@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Aug 31, 2022
@stale stale bot closed this as completed Sep 14, 2022
Repository owner moved this from Not started to Done in PatternFly Issues Sep 14, 2022
@thatblindgeye thatblindgeye reopened this Sep 14, 2022
@nicolethoen nicolethoen moved this from Done to Not started in PatternFly Issues Sep 20, 2022
@mcarrano mcarrano modified the milestones: Demo backlog, 2022.15, 2023.02 Sep 20, 2022
@mcarrano mcarrano modified the milestones: 2023.02, 2022.16 Oct 26, 2022
@mcarrano mcarrano added the PF4 label Nov 8, 2022
@mcarrano mcarrano modified the milestones: 2022.16, 2023.02 Nov 11, 2022
@tlabaj tlabaj modified the milestones: 2023.02, Prioritized Backlog Dec 6, 2022
@stale
Copy link

stale bot commented Feb 5, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Feb 5, 2023
@nicolethoen nicolethoen removed the PF5 label Mar 7, 2023
@thatblindgeye
Copy link
Contributor Author

For additional context, this isn't a bug with only Skip To Content demo(s). Testing a full screen Page demo, clicking the SkipToContent with keyboard and then pressing the Tab key, the SkipToContent button receives focus again instead of the next focusable element within the "main content".

Copy link

stale bot commented Nov 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Nov 7, 2023
Copy link

stale bot commented Jan 9, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 9, 2024
Copy link

stale bot commented Mar 12, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 12, 2024
@stale stale bot closed this as completed Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Not started to Done in PatternFly Issues Apr 18, 2024
@thatblindgeye thatblindgeye reopened this Apr 18, 2024
@stale stale bot removed the wontfix label Apr 18, 2024
@github-project-automation github-project-automation bot moved this from Done to Needs triage in PatternFly Issues Apr 18, 2024
@tlabaj tlabaj moved this from Needs triage to Backlog in PatternFly Issues Apr 18, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Copy link

This issue has been automatically marked as stale because it has not had recent activity.

@rebeccaalpert
Copy link
Member

Still an issue in 6!

@rebeccaalpert rebeccaalpert self-assigned this Nov 19, 2024
@tlabaj tlabaj moved this from Backlog to Ready to assign in PatternFly Issues Nov 19, 2024
@tlabaj tlabaj modified the milestones: Prioritized Backlog, 2025.Q1 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

No branches or pull requests

6 participants