Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Page - Skip to content doesn't work #11162

Closed
rebeccaalpert opened this issue Nov 5, 2024 · 1 comment
Closed

Bug - Page - Skip to content doesn't work #11162

rebeccaalpert opened this issue Nov 5, 2024 · 1 comment

Comments

@rebeccaalpert
Copy link
Member

rebeccaalpert commented Nov 5, 2024

Describe the problem
The Page demos that include Skip to content do not actually skip to content when the button is clicked: https://www.patternfly.org/components/page/react-demos

The HTML demos seem to demonstrate this behavior, however: https://www.patternfly.org/components/page/html-demos/basic/#main-content-page-demo-basic

As does the plain component: https://www.patternfly.org/components/skip-to-content

Likely something is up with the Page component.

How do you reproduce the problem?
Go to https://www.patternfly.org/components/page/react-demos/sticky-section-group/#main-content. Try to use Skip to content. You see a brief flash of focus and then the page reloads.

Expected behavior
Page should focus the main section.

Is this issue blocking you?
Not really. We'd like to add a skip to chatbot link in Virtual Assistant. I'd like to demonstrate it with a skip to content link, but I can't do that if this doesn't work. I can use refs for now.

What is your environment?

  • OS: [e.g. iOS] Mac
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] Version 130.0.6723.91

What is your product and what release date are you targeting?
N/A

@rebeccaalpert
Copy link
Member Author

rebeccaalpert commented Nov 5, 2024

@thatblindgeye pointed out that this is a dupe of #7554. Closing, but we should really fix #7554 rather than letting it kick around another two whole years. ⭐

@github-project-automation github-project-automation bot moved this from Needs triage to Done in PatternFly Issues Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant