Skip to content

feat(Select/Dropdown/MenuContainer): arrow key handling to focus items #1529

feat(Select/Dropdown/MenuContainer): arrow key handling to focus items

feat(Select/Dropdown/MenuContainer): arrow key handling to focus items #1529

Triggered via pull request November 20, 2024 10:52
Status Success
Total duration 7m 22s
Artifacts 1

main.yml

on: pull_request
Matrix: Integration tests
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Lint: packages/react-charts/src/victory/components/ChartUtils/chart-patterns.tsx#L349
Mutating component props or hook arguments is not allowed. Consider using a local variable instead
Lint: packages/react-core/src/components/BackToTop/BackToTop.tsx#L36
The 'toggleVisible' function makes the dependencies of useEffect Hook (at line 74) change on every render. Move it inside the useEffect callback. Alternatively, wrap the definition of 'toggleVisible' in its own useCallback() Hook
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L184
React Hook useEffect has a missing dependency: 'focusedDate'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx#L191
React Hook useEffect has a missing dependency: 'shouldFocus'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/Card/examples/CardWithModifiers.tsx#L18
This mutates a variable that React considers immutable
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L134
React Hook React.useMemo has a missing dependency: 'placeholder.length'. Either include it or remove the dependency array
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L145
React Hook React.useEffect has a missing dependency: 'dateParse'. Either include it or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L151
React Hook React.useEffect has missing dependencies: 'applyValidators' and 'valueDate'. Either include them or remove the dependency array
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L162
React Hook React.useEffect has missing dependencies: 'applyValidators', 'dateIsRequired', 'dateParse', 'emptyDateText', 'errorText', 'pristine', and 'textInputFocused'. Either include them or remove the dependency array. If 'dateParse' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint: packages/react-core/src/components/DatePicker/DatePicker.tsx#L228
React Hook useImperativeHandle has an unnecessary dependency: 'selectOpen'. Either exclude it or remove the dependency array

Artifacts

Produced during runtime
Name Size
demo-app
636 KB