Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(continue): Fix continue button behavior #272

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

jschuler
Copy link
Collaborator

@jschuler jschuler commented Oct 30, 2023

Fixes the Continue button behavior, so it will only skip past the Succeeded tasks.

I think this also fixes #249
Closes #249

Before:

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for quickstarts ready!

Name Link
🔨 Latest commit c253eca
🔍 Latest deploy log https://app.netlify.com/sites/quickstarts/deploys/653fd9fd5658f9000811aecc
😎 Deploy Preview https://deploy-preview-272--quickstarts.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wise-king-sullyman
Copy link
Contributor

I think I'm still seeing the issue from #249?

@jschuler
Copy link
Collaborator Author

@wise-king-sullyman i need to rebase one moment

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep looks great now!

@wise-king-sullyman wise-king-sullyman merged commit 8460076 into main Oct 30, 2023
8 checks passed
@github-actions
Copy link

🎉 This PR is included in version 5.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close button in QuickStartFooter doesn't always close
2 participants