Avoid overflow of index #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
May 11, 2017
| @@ -19,7 +19,7 @@ object ImmutableRoundRobin { | |||
|
|
|||
| private def activeRoutingBehavior[T](index: Long, workers: Vector[ActorRef[T]]): Behavior[T] = | |||
| Actor.immutable[T] { (ctx, msg) => | |||
| workers((index % workers.size).toInt) ! msg | |||
| workers(abs(index % workers.size).toInt) ! msg | |||
There was a problem hiding this comment.
it's a Long so you would have to run for very long before you wrap around (292471 years if the throughput is 1M msg/s)
There was a problem hiding this comment.
Well, it's all about correctness. And who knows, in the past numeric ranges have been underestimated several times ;-)
There was a problem hiding this comment.
alright, then update to the more correct https://github.com/akka/akka/blob/master/akka-actor/src/main/scala/akka/routing/RoundRobin.scala#L30
otherwise it will not be strict round robin when wrapping around
also update other code: MutableRoundRobin.scala, ImmutableRoundRobin.java, MutableRoundRobin.java
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.