Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi! I cleaned up your code for you! #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hi! I cleaned up your code for you! #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# Compiled source #
###################
*.com
*.class
*.dll
*.exe
*.o
*.so
*.pyc

# Numerous always-ignore extensions
###################
*.diff
*.err
*.orig
*.log
*.rej
*.swo
*.swp
*.vi
*~

*.sass-cache
# Folders to ignore
###################
.hg
.svn
.CVS
# OS or Editor folders
###################
.DS_Store
Icon?
Thumbs.db
ehthumbs.db
nbproject
.cache
.project
.settings
.tmproj
*.esproj
*.sublime-project
*.sublime-workspace
# Dreamweaver added files
###################
_notes
dwsync.xml
# Komodo
###################
*.komodoproject
.komodotools
6 changes: 3 additions & 3 deletions README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ TODO

Work with all the various WYSIWYG editors.
* TinyMCE supported -- tested on 3.3.6
* FCKEditor
* FCKEditor
* WYMediator
* openWYSIWYG
* markItUp
Expand All @@ -43,7 +43,7 @@ Work with all the various WYSIWYG editors.
* NiceEdit
* Whizzywig

Test across browsers.

Test across browsers.

Research better form for bringing in jQuery within the module itself?
6 changes: 3 additions & 3 deletions README.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ TODO

Work with all the various WYSIWYG editors.
* TinyMCE supported -- tested on 3.3.6
* FCKEditor
* FCKEditor
* WYMediator
* openWYSIWYG
* markItUp
Expand All @@ -43,7 +43,7 @@ Work with all the various WYSIWYG editors.
* NiceEdit
* Whizzywig

Test across browsers.

Test across browsers.

Research better form for bringing in jQuery within the module itself?
24 changes: 12 additions & 12 deletions css/open_review-rtl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

.indent {
margin-left: 20px;
background-color: red;
background-color: red;
}

.open-review-active {
background-color: yellow;
background-color: yellow;
}

.open-review-view-dialog-comment {
Expand All @@ -21,22 +21,22 @@
cursor: pointer;
padding-left: 20px;
background-image: url('icons/comments.png');
background-repeat: no-repeat;
background-repeat: no-repeat;
}

div.ui-dialog .open-review-comment-open-on-para {
display: none;
}

p.open-review-para {
p.open-review-para {
min-height: 50px;
}


span.open-review-para-actions {
display:block;
float:right;
padding-left: 5px;
padding-left: 5px;
}


Expand All @@ -53,7 +53,7 @@ span.open-review-para-view {
display: block;
cursor: pointer;
width: 20px;
height: 20px;
height: 20px;
padding-right: 20px;
background-image: url('icons/comments.png');
background-repeat: no-repeat;
Expand All @@ -62,10 +62,10 @@ span.open-review-para-view {
span.open-review-new {
display: block;
width: 20px;
height: 20px;
height: 20px;
padding-left: 20px;
background-image: url('icons/new.png');
background-repeat: no-repeat;
background-repeat: no-repeat;
}
div#open-review-comments {
width: 30%;
Expand All @@ -77,7 +77,7 @@ div#open-review-comments {
height: auto;
margin: 0;
width: auto;

}

div.ui-dialog {
Expand All @@ -96,16 +96,16 @@ div.ui-dialog-titlebar {
}

span#ui-dialog-title-dialog {

}



di#dialog {

}
div.ui-dialog-content {

}


24 changes: 12 additions & 12 deletions css/open_review.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@

.indent {
margin-left: 20px;
background-color: red;
background-color: red;
}

.open-review-active {
background-color: yellow;
background-color: yellow;
}

.open-review-view-dialog-comment {
Expand All @@ -21,22 +21,22 @@
cursor: pointer;
padding-left: 20px;
background-image: url('icons/comments.png');
background-repeat: no-repeat;
background-repeat: no-repeat;
}

div.ui-dialog .open-review-comment-open-on-para {
display: none;
}

p.open-review-para {
p.open-review-para {
min-height: 50px;
}


span.open-review-para-actions {
display:block;
float:left;
padding-right: 5px;
padding-right: 5px;
}


Expand All @@ -53,18 +53,18 @@ span.open-review-para-view {
display: block;
cursor: pointer;
width: 20px;
height: 20px;
height: 20px;
padding-left: 20px;
background-image: url('icons/comments.png');
background-repeat: no-repeat;
}
span.open-review-new {
display: block;
width: 20px;
height: 20px;
height: 20px;
padding-left: 20px;
background-image: url('icons/new.png');
background-repeat: no-repeat;
background-repeat: no-repeat;
}
div#open-review-comments {
width: 30%;
Expand All @@ -76,7 +76,7 @@ div#open-review-comments {
height: auto;
margin: 0;
width: auto;

}

div.ui-dialog {
Expand All @@ -95,16 +95,16 @@ div.ui-dialog-titlebar {
}

span#ui-dialog-title-dialog {

}



di#dialog {

}
div.ui-dialog-content {

}


2 changes: 1 addition & 1 deletion js/jquery/themes/base/ui.dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
----------------------------------*/
.ui-dialog { position: relative; padding: .2em; width: 300px; }
.ui-dialog .ui-dialog-titlebar { padding: .5em .3em .3em 1em; position: relative; }
.ui-dialog .ui-dialog-title { float: left; margin: .1em 0 .2em; }
.ui-dialog .ui-dialog-title { float: left; margin: .1em 0 .2em; }
.ui-dialog .ui-dialog-titlebar-close { position: absolute; right: .3em; top: 50%; width: 19px; margin: -10px 0 0 0; padding: 1px; height: 18px; }
.ui-dialog .ui-dialog-titlebar-close span { display: block; margin: 1px; }
.ui-dialog .ui-dialog-titlebar-close:hover, .ui-dialog .ui-dialog-titlebar-close:focus { padding: 0; }
Expand Down
4 changes: 2 additions & 2 deletions js/jquery/themes/ui-lightness/jquery-ui-1.7.2.custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@
.ui-datepicker .ui-datepicker-title { margin: 0 2.3em; line-height: 1.8em; text-align: center; }
.ui-datepicker .ui-datepicker-title select { float:left; font-size:1em; margin:1px 0; }
.ui-datepicker select.ui-datepicker-month-year {width: 100%;}
.ui-datepicker select.ui-datepicker-month,
.ui-datepicker select.ui-datepicker-month,
.ui-datepicker select.ui-datepicker-year { width: 49%;}
.ui-datepicker .ui-datepicker-title select.ui-datepicker-year { float: right; }
.ui-datepicker table {width: 100%; font-size: .9em; border-collapse: collapse; margin:0 0 .4em; }
Expand Down Expand Up @@ -353,7 +353,7 @@
----------------------------------*/
.ui-dialog { position: relative; padding: .2em; width: 300px; }
.ui-dialog .ui-dialog-titlebar { padding: .5em .3em .3em 1em; position: relative; }
.ui-dialog .ui-dialog-title { float: left; margin: .1em 0 .2em; }
.ui-dialog .ui-dialog-title { float: left; margin: .1em 0 .2em; }
.ui-dialog .ui-dialog-titlebar-close { position: absolute; right: .3em; top: 50%; width: 19px; margin: -10px 0 0 0; padding: 1px; height: 18px; }
.ui-dialog .ui-dialog-titlebar-close span { display: block; margin: 1px; }
.ui-dialog .ui-dialog-titlebar-close:hover, .ui-dialog .ui-dialog-titlebar-close:focus { padding: 0; }
Expand Down
2 changes: 1 addition & 1 deletion js/jquery/themes/ui-lightness/ui.datepicker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
.ui-datepicker .ui-datepicker-title { margin: 0 2.3em; line-height: 1.8em; text-align: center; }
.ui-datepicker .ui-datepicker-title select { float:left; font-size:1em; margin:1px 0; }
.ui-datepicker select.ui-datepicker-month-year {width: 100%;}
.ui-datepicker select.ui-datepicker-month,
.ui-datepicker select.ui-datepicker-month,
.ui-datepicker select.ui-datepicker-year { width: 49%;}
.ui-datepicker .ui-datepicker-title select.ui-datepicker-year { float: right; }
.ui-datepicker table {width: 100%; font-size: .9em; border-collapse: collapse; margin:0 0 .4em; }
Expand Down
2 changes: 1 addition & 1 deletion js/jquery/themes/ui-lightness/ui.dialog.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
----------------------------------*/
.ui-dialog { position: relative; padding: .2em; width: 300px; }
.ui-dialog .ui-dialog-titlebar { padding: .5em .3em .3em 1em; position: relative; }
.ui-dialog .ui-dialog-title { float: left; margin: .1em 0 .2em; }
.ui-dialog .ui-dialog-title { float: left; margin: .1em 0 .2em; }
.ui-dialog .ui-dialog-titlebar-close { position: absolute; right: .3em; top: 50%; width: 19px; margin: -10px 0 0 0; padding: 1px; height: 18px; }
.ui-dialog .ui-dialog-titlebar-close span { display: block; margin: 1px; }
.ui-dialog .ui-dialog-titlebar-close:hover, .ui-dialog .ui-dialog-titlebar-close:focus { padding: 0; }
Expand Down
2 changes: 1 addition & 1 deletion js/jquery/ui/effects.core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ function _normalizeArguments(a, m) {
var callback = o.callback || ( $.isFunction(a[1]) && a[1] ) || ( $.isFunction(a[2]) && a[2] ) || ( $.isFunction(a[3]) && a[3] );

return [a[0], o, speed, callback];

}

//Extend the methods of jQuery
Expand Down
Loading