Can we use chartjs-node-canvas instead of chartjs-node? #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisidovski
changed the title
There was a problem hiding this comment.
thanks @sisidovski!
just the one note about color contrast but otherwise this is great :)
| "chart.js": "^2.8.0", | ||
| "chartjs-node": "^1.7.1", | ||
| "chart.js": "^2.9.4", | ||
| "chartjs-node-canvas": "^3.2.0", |
There was a problem hiding this comment.
the new legend text is extremely hard to read, could we fix the font color there?
There was a problem hiding this comment.
Ah that is correct, let me check.
sisidovski
force-pushed
the
use-chartjs-node-canvas
branch
from
e10a0b7 to
6ea5405
Compare
sisidovski
force-pushed
the
use-chartjs-node-canvas
branch
from
6ea5405 to
1d38fb3
Compare
|
The legend is still slightly different, but now it has the better color contrast. WDYT? @patrickhulce |
patrickhulce
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I tried to update README.md file, but I couldn't install chartjs-node library on the current master branch because of node-gyp error. Maybe similar to vmpowerio/chartjs-node#85, I couldn't fix this installation issue on my local machine (Mac OS 11.3.1, node.js v16.4.2).
I don't know how reasonable it is, but It looks like chartjs-node is not actively maintained anymore. So can we use chartjs-node-canvas instead?