Java 20 compat, module-info.java #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @patrickfav,
This PR is aiming at giving some support to this similar PR w/ Blake2B and @kjetilkl: rfksystems/blake2b#2
The original work for Crypt4GH is happening here: uio-bmi/crypt4gh#85 (comment)
The motivation for the changes comprised here is well described in that description, so I'll not repeat it here.
A particularity of your library is that I couldn't (easily) migrate JaCoCo, there's a long string of errors if enabled. Tests pass for now, so if you can review the PR and advise I can revisit and try to fix that one for you?
I'll make similar modifications to your
bcryptdependant library if you are happy with those in here?