Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
qadence-libs
compatible with the newqadence
, in particular changing how the oldTransformedModule
was dealt with. In the QNG optimizer we need to distinguish the "circuit" variational parameters (those params that affect the final quantum state of the ciruict, e.g. gate params or FM params) and "non-circuit" variational parameters (e.g. the parameters modifying the observable, which do no change the final quantum state). This is because only circuit params can be optimized with the QNG optimizer (we can only compute the QFI matrix for circuit params). Before, it was easier to distinguish both as non-circuit parameters corresponded to theTransformedModule
scale and shifting, but now some new logic was needed to distinguish both.Apart from adding this new logic, I refactored the code inside
qng.py
so that the different approximations have now a functional API form, more in line withtorch
style, and also extended the documentation a bit.