[IMPROVEMENT] Replace DeviceType with EmulatorType

[Augustinio]

https://gitlab.pasqal.com/pcs/public-apis/-/issues/527

Cf changelog

[anneclairelh]

I am sure there is a good reason but I'm not sure to see it, why are we doing this change ?

[Augustinio]

@anneclairelh for some reason I can't reply directly to your comment.

Basically the QPU DeviceType was never really used. It was just a flag to indicate that we weren't using emulators. Since QPU device types are extracted from the sequence.

In public-apis we're removing QPU as a device type since it's not an actual device type and lead to confusion regarding what it meant. Similarly it's a way to make the code clearer and avoid users to potentially get confused with the meaning of this QPU device type.

[anneclairelh]

@anneclairelh for some reason I can't reply directly to your comment.

Basically the QPU DeviceType was never really used. It was just a flag to indicate that we weren't using emulators. Since QPU device types are extracted from the sequence.

In public-apis we're removing QPU as a device type since it's not an actual device type and lead to confusion regarding what it meant. Similarly it's a way to make the code clearer and avoid users to potentially get confused with the meaning of this QPU device type.

Of course, but my question is, do we know that we won't have other QPU device types ? Is the intention behind this that we don't want to expose device types like "FRESNEL" in a public repo ?

[anneclairelh]

I am sure there is a good reason but I'm not sure to see it, why are we doing this change ?

Indeed Github is pretty bad and only allows you to quote ;)

[MatthieuMoreau0]

@anneclairelh

Of course, but my question is, do we know that we won't have other QPU device types ? Is the intention behind this that we don't want to expose device types like "FRESNEL" in a public repo ?

We will have other QPU device type, we just don't want to hard code it inside the SDK, as these can be fetched directly from the cloud device specs anyway (and we don't want to have to update the package everytime we add a QPU to the list). Moreover to select a precise QPU, the user will select it directly inside their pulser sequence.

Having an extra argument on the SDK was making things confusing, the user would select device_type=QPU but the resulting batch would have its attribute device_type set to something like IROISEMVP

[MatthieuMoreau0]

Nice job LGTM, one tiny suggestion

[MatthieuMoreau0]

nit: for convenience for the users, could we export these objects in the sdk.device module ?

[Augustinio]

Done

[MatthieuMoreau0]

This introduces breaking changes can you bump the minor instead of the patch please to follow semantic versioning ? See #73

[Augustinio]

This introduces breaking changes can you bump the minor instead of the patch please to follow semantic versioning ? See #73

new version is 0.2.0