You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now that other libraries (e.g. pulser-pasqal) depend on the cloud-sdk, it would be great if the versioning could start following the Semantic Versioning 2.0.0 specifcation to avoid strictly pinning the cloud-sdk version in the dependencies (I see this has already been suggested in #58).
Actually, I was under the impression that this was already the case, so the last update to pulser-pasqal changed the cloud-sdk requirement to be ~=0.1.12.
However, it seems that some breaking changes were introduced since then and v0.1.15 (the latest release at the time of writing). In particular, it seems that Endpoints() no longer accepts an account keyword argument, which is causing some of our tests to fail:
@pytest.fixture
def fixt():
with patch("sdk.SDK", autospec=True) as mock_cloud_sdk_class:
pasqal_cloud_kwargs = dict(
username="abc",
***,
group_id="ghi",
> endpoints=Endpoints(core="core_url", account="account_url"),
webhook="xyz",
)
E TypeError: __init__() got an unexpected keyword argument 'account'
I'm wondering, is there something that's preventing you from increasing MINOR instead of PATCH that I don't know about?
The text was updated successfully, but these errors were encountered:
Hey @HGSilveri sorry for the inconvenience definitely an oversight on our part, we'll be more careful in the upcoming releases. For now I'd suggest pinning strictly to the version compatible with your usage and unpinning it whenever you have made the changes to match our new API. You can refer to the changelog for the list of changes.
We'll focus on backwards compatibility for the upcoming releases!
Now that other libraries (e.g.
pulser-pasqal
) depend on thecloud-sdk
, it would be great if the versioning could start following the Semantic Versioning 2.0.0 specifcation to avoid strictly pinning thecloud-sdk
version in the dependencies (I see this has already been suggested in #58).Actually, I was under the impression that this was already the case, so the last update to
pulser-pasqal
changed thecloud-sdk
requirement to be~=0.1.12
.However, it seems that some breaking changes were introduced since then and
v0.1.15
(the latest release at the time of writing). In particular, it seems thatEndpoints()
no longer accepts anaccount
keyword argument, which is causing some of our tests to fail:I'm wondering, is there something that's preventing you from increasing MINOR instead of PATCH that I don't know about?
The text was updated successfully, but these errors were encountered: