Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JVP implementation of parameter shift rule #27

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

atiyo
Copy link
Collaborator

@atiyo atiyo commented Sep 3, 2024

A first implementation of the parameter shift rule.

In the first instance, we have the following limitations:

  • We only allow derivatives of expectations with respects to values. In the future it would be cool to allow derivatives with respect to gates as well.
  • Spectral gaps are hard-coded, whereas they could be read from the corresponding primitive in the future.

Closes #22

@atiyo atiyo self-assigned this Sep 4, 2024
Copy link
Collaborator

@jpmoutinho jpmoutinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to say, LGTM!

@atiyo atiyo merged commit 77084a5 into main Sep 9, 2024
6 checks passed
@atiyo atiyo deleted the feature/shots_psr branch September 9, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add GPSR jvp implementation
2 participants