Use jobs order provided by the cloud #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-corni
reviewed
Sep 21, 2023
Comment on lines
-211
to
-220
| job_params[0]["runs"] = 1 | ||
| with pytest.raises(RuntimeError, match="Failed to find job ID"): | ||
| # Job runs don't match MockJob | ||
| fixt.pasqal_cloud.submit( | ||
| seq, | ||
| job_params=job_params, | ||
| emulator=emulator, | ||
| config=config, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Why is this test no longer relevant ?
There was a problem hiding this comment.
Because we no longer try to determine the jobs order (the code where this was being raised was deleted)
There was a problem hiding this comment.
Okay, that was my guess... So it's no longer an issue that the number of runs in job_params is different than number of runs in "mock_job" ? The two issues seemed independent to me, but I am not I understood the test in the first place...
There was a problem hiding this comment.
That manual change was just a way for the job params to not match anymore and thus trigger the fail to find the job ID.
a-corni
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #570 .