Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an info comment to translations #40

Merged
merged 2 commits into from
May 31, 2024
Merged

Adds an info comment to translations #40

merged 2 commits into from
May 31, 2024

Conversation

rchowell
Copy link
Contributor

@rchowell rchowell commented May 28, 2024

Issue #, if available:

#37

Description of changes:

Adds an info comment at the beginning of translations.

Example

--#[select-10]
SELECT t.c || CURRENT_USER FROM T;


-- PartiQL 0.0 // Scribe @ 0.1.0-15b1754 
SELECT "T"['c'] || CURRENT_USER AS "_1" FROM "default"."T" AS "T"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting to remove the accidentally added public API. Beyond that, looks good.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

@rchowell rchowell merged commit 2b781bd into main May 31, 2024
@rchowell rchowell deleted the comment-tag branch May 31, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants