-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System: make sure that the power source being USB host is well detected #2310
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,6 +70,9 @@ constexpr uint16_t PMIC_FAULT_TERM_CHARGE_CURRENT = 128; // mA | |
constexpr system_tick_t BATTERY_REPEATED_CHARGED_WINDOW = 5000; // ms | ||
constexpr uint8_t BATTERY_REPEATED_CHARGED_COUNT = 2; | ||
|
||
constexpr system_tick_t DPDM_PERIOD = 1000; | ||
constexpr uint8_t DPDM_RETRY_COUNT = 3; | ||
|
||
constexpr hal_power_config defaultPowerConfig = { | ||
.flags = 0, | ||
.version = 0, | ||
|
@@ -321,10 +324,11 @@ void PowerManager::handleUpdate() { | |
break; | ||
} | ||
} else { | ||
if (g_batteryState == BATTERY_STATE_DISCHARGING) { | ||
src = POWER_SOURCE_BATTERY; | ||
} else { | ||
src = POWER_SOURCE_UNKNOWN; | ||
// Do not update power source if power is good and in DPDM | ||
if (!pwr_good || !power.isInDPDM()) { | ||
if (g_batteryState == BATTERY_STATE_DISCHARGING) { | ||
src = POWER_SOURCE_BATTERY; | ||
} | ||
} | ||
} | ||
|
||
|
@@ -424,6 +428,7 @@ void PowerManager::loop(void* arg) { | |
} | ||
self->checkWatchdog(); | ||
self->deduceBatteryStateLoop(); | ||
self->runDpdm(); | ||
} | ||
|
||
exit: | ||
|
@@ -505,6 +510,31 @@ void PowerManager::initDefault(bool dpdm) { | |
clearIntermediateBatteryState(STATE_ALL); | ||
} | ||
|
||
void PowerManager::runDpdm() { | ||
// FIXME: maybe introduce a new flag? | ||
#if HAL_PLATFORM_POWER_WORKAROUND_USB_HOST_VIN_SOURCE | ||
static system_tick_t lastRun = 0; | ||
static uint8_t dpdmRetry = 0; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move these into the class member variables. |
||
|
||
if (millis() - lastRun >= DPDM_PERIOD) { | ||
lastRun = millis(); | ||
if (g_powerSource == POWER_SOURCE_VIN && HAL_USB_Get_State(nullptr) >= HAL_USB_STATE_POWERED) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what other states are caught by |
||
if (dpdmRetry >= DPDM_RETRY_COUNT) { | ||
return; | ||
} | ||
PMIC power(true); | ||
if (power.isInDPDM()) { | ||
return; | ||
} | ||
power.enableDPDM(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is going to cause dips to 100mA current temporarily and may cause for example the modem to brownout if there is no battery attached. See #2215 for some additional info. We should probably opt to just reporting |
||
dpdmRetry++; | ||
} else { | ||
dpdmRetry = 0; | ||
} | ||
} | ||
#endif | ||
} | ||
|
||
void PowerManager::confirmBatteryState(battery_state_t from, battery_state_t to) { | ||
// Whenever we confirm the battery state, we re-start the monitor cycle | ||
batMonitorTimeStamp_ = millis(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be this be
!power.isInDPDM() && !pwr_good
?