-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add element for subset of data to info panel #2622
base: alpha
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,7 +45,7 @@ export default class DataBrowser extends React.Component { | |
firstSelectedCell: null, | ||
selectedData: [], | ||
prevClassName: props.className, | ||
panelWidth: 300, | ||
panelWidth: 400, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why this change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, both of them were unintentional changes, i will revert them back in next commit. |
||
isResizing: false, | ||
maxWidth: window.innerWidth - 300, | ||
showAggregatedData: true, | ||
|
@@ -591,7 +591,7 @@ export default class DataBrowser extends React.Component { | |
<ResizableBox | ||
width={this.state.panelWidth} | ||
height={Infinity} | ||
minConstraints={[100, Infinity]} | ||
minConstraints={[400, Infinity]} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please revert if not required for this PR; the panel should be resizable to min. 100 px width. |
||
maxConstraints={[this.state.maxWidth, Infinity]} | ||
onResizeStart={this.handleResizeStart} // Handle start of resizing | ||
onResizeStop={this.handleResizeStop} // Handle end of resizing | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of introducing another
PanelElement
I would suggest to extend existing one (inAggregationPanel.js
), and adopt it to loading data subset and being used recessively. This way we should avoid code duplication.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried doing in the latest commits, can you please review it?