Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add client access via ParseDioClient.client and ParseHTTPClient.client #1025

Merged
merged 6 commits into from
Dec 18, 2024
Merged

feat: Add client access via ParseDioClient.client and ParseHTTPClient.client #1025

merged 6 commits into from
Dec 18, 2024

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Nov 28, 2024 •
edited
Loading

Pull Request

Issue

Closes: #1023

Approach

Add a function to access client in parse clients.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: add access client in parse clients fix: Add access client in parse clients Nov 28, 2024
@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this pull request!

@mbfakourii mbfakourii changed the title fix: Add access client in parse clients fix: add access client in parse clients Nov 28, 2024
@parse-github-assistant Parse GitHub Assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: add access client in parse clients fix: Add access client in parse clients Nov 28, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.26%. Comparing base (c388545) to head (8f763cb).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1025      +/-   ##
==========================================
+ Coverage   43.37%   47.26%   +3.88%     
==========================================
  Files          61       53       -8     
  Lines        3463     3140     -323     
==========================================
- Hits         1502     1484      -18     
+ Misses       1961     1656     -305

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbfakourii mbfakourii requested a review from a team November 28, 2024 14:23
chadpav
chadpav approved these changes Nov 30, 2024
View reviewed changes
Copy link

@chadpav chadpav left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straight forward.

@mtrezza
Copy link
Member

mtrezza commented Nov 30, 2024

Could you rephrase the PR title to better understand the new feature? Maybe also add the class or method name.

mtrezza
mtrezza reviewed Nov 30, 2024
View reviewed changes
packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved
packages/dart/lib/src/network/parse_dio_client.dart Outdated Show resolved Hide resolved
@mbfakourii mbfakourii requested a review from a team December 17, 2024 05:10
mtrezza
mtrezza reviewed Dec 18, 2024
View reviewed changes
packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title fix: Add access client in parse clients fix: Add client access via ParseDioClient.dioClient and ParseHTTPClient.httpClient Dec 18, 2024
mtrezza
mtrezza reviewed Dec 18, 2024
View reviewed changes
packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved
@mtrezza mtrezza changed the title fix: Add client access via ParseDioClient.dioClient and ParseHTTPClient.httpClient feat: Add client access via ParseDioClient.dioClient and ParseHTTPClient.httpClient Dec 18, 2024
mtrezza
mtrezza previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; if the new PR title makes sense, then I'll go ahead and merge.

mtrezza
mtrezza reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 thing:

Would it make sense to name the properties just client as in ParseDioClient.client, ParseHTTPClient.client? The class names already say what type of client it is.

@mbfakourii
Copy link
Member Author

Just 1 thing:

Would it make sense to name the properties just client as in ParseDioClient.client, ParseHTTPClient.client? The class names already say what type of client it is.

Good suggestion.

@mbfakourii
Copy link
Member Author

Just 1 thing:

Would it make sense to name the properties just client as in ParseDioClient.client, ParseHTTPClient.client? The class names already say what type of client it is.

Changed.

@mtrezza mtrezza changed the title feat: Add client access via ParseDioClient.dioClient and ParseHTTPClient.httpClient feat: Add client access via ParseDioClient.client and ParseHTTPClient.client Dec 18, 2024
mtrezza
mtrezza approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit af14388 into parse-community:master Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

@chadpav chadpav chadpav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access dio or http client in ParseDioClient or ParseHTTPClient
3 participants
@mbfakourii @mtrezza @chadpav