Feat: impl db snap logic for k8s/native #180
Conversation
| @@ -156,7 +156,8 @@ where | |||
| .map(|var| (var.name.clone(), var.value.clone())), | |||
| ) | |||
| .injected_files(files_to_inject) | |||
| .created_paths(created_paths); | |||
| .created_paths(created_paths) | |||
There was a problem hiding this comment.
We can remove this, there is no need to use created_paths now that it's created on send_file
There was a problem hiding this comment.
We still need this for native, we should abstract in some way for both providers in a follow up pr.
There was a problem hiding this comment.
You are right, we should probably at it here (as the Kubernetes provider):
| async fn upload_to_fileserver(&self, location: &Path) -> Result<Url, ProviderError> { | ||
| let data = self.filesystem.read(location).await?; | ||
| let hashed_path = hex::encode(sha2::Sha256::digest(&data)); | ||
| let req = self | ||
| .http_client | ||
| .head(format!( | ||
| "http://{}/{hashed_path}", | ||
| self.file_server_local_host().await? | ||
| )) | ||
| .build() | ||
| .map_err(|err| { | ||
| ProviderError::UploadFile(location.to_string_lossy().to_string(), err.into()) | ||
| })?; | ||
|
|
||
| let url = req.url().clone(); | ||
| let res = self.http_client.execute(req).await.map_err(|err| { | ||
| ProviderError::UploadFile(location.to_string_lossy().to_string(), err.into()) | ||
| })?; | ||
|
|
||
| if res.status() != reqwest::StatusCode::OK { | ||
| // we need to upload the file | ||
| self.http_client | ||
| .post(url.as_ref()) | ||
| .body(data) | ||
| .send() | ||
| .await | ||
| .map_err(|err| { |
There was a problem hiding this comment.
What is the difference with send_file below ? You want to update without copying to the pod ? Then maybe split the logic below in 2 parts and have a function used where we need ? wdyt ?
There was a problem hiding this comment.
Yes, sounds good. We should split the send_file (upload/download) since we don't always want to just copy to one pod.
There was a problem hiding this comment.
We also hashed the file content here since we want to dedup the upload phase of the process. I will open an issue to track this refactor in a followup pr.
|
Follow up issue #182, merging now. |
Add:
db_snapshot