Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

OLD - Prepare Trappist v1.3.0 release #319

Closed
wants to merge 7 commits into from

Conversation

metricaez
Copy link
Collaborator

No description provided.

@metricaez metricaez changed the title Prepare v1.3 upgrade Prepare Trappist v1.3 release Dec 8, 2023
@metricaez metricaez changed the title Prepare Trappist v1.3 release Prepare Trappist v1.3.0 release Dec 8, 2023
@metricaez
Copy link
Collaborator Author

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Dec 8, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4664433 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-9c41d5d2-430b-4cb3-a5aa-9c10e9e8bbc1 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 8, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4664433 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4664433/artifacts/download.

@stiiifff
Copy link
Contributor

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Dec 11, 2023

@stiiifff https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4679970 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-b03277c5-e82c-4f47-8636-665cedebdc18 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 11, 2023

@stiiifff Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4679970 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4679970/artifacts/download.

@metricaez
Copy link
Collaborator Author

Note: 8f098de adds a benchmark helper needed to generate an existencial deposit for the beneficiary created for the benchmark. pallet_treasury benchmark by default transfers 100 tokens and in Trappist's case it didn't meet minimum balance triggering a Payout Error shadowing a BelowMinimum token error.

@metricaez
Copy link
Collaborator Author

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Dec 14, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4727867 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-3e801f88-695c-450a-a7bc-42612e050401 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 14, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4727867 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4727867/artifacts/download.

@metricaez
Copy link
Collaborator Author

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Dec 16, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4741333 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-4d799fe4-4c3b-4813-b485-1cf1f47b5b79 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 16, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4741333 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4741333/artifacts/download.

@metricaez
Copy link
Collaborator Author

Note: These assets are now being considered here. Therefore the reason of it causing problems now even though it's been months with the same setup.

@metricaez
Copy link
Collaborator Author

bot bench-all trappist

@command-bot
Copy link

command-bot bot commented Dec 18, 2023

@metricaez https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4749505 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist. Check out https://gitlab.parity.io/parity/mirrors/trappist/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-11973f2e-de9e-437f-99c5-c461cf200833 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Dec 18, 2023

@metricaez Command "$PIPELINE_SCRIPTS_DIR/commands/bench-all/bench-all.sh" --runtime=trappist --target_dir=trappist has finished. Result: https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4749505 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/trappist/-/jobs/4749505/artifacts/download.

@metricaez metricaez changed the title Prepare Trappist v1.3.0 release OLD - Prepare Trappist v1.3.0 release Dec 19, 2023
@metricaez metricaez closed this Dec 19, 2023
@metricaez
Copy link
Collaborator Author

Closing as benchmarks were passing because I changed them to the ones from balances, even though the issue is the one stated, the solution is incorrect and reverting would add yet more unnecessary info. Opening a new PR now.

@metricaez metricaez deleted the emi-prepare-v13000-release branch December 27, 2023 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants