This repository has been archived by the owner on May 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metricaez
commented
Oct 17, 2023
- Implemented emulator from polkadot-sdk
- Migrated tests from simulator to emulator
- Fixed xcm config for reserve transfer from Trappist to Stout use case to pass with current runtimes
- Left duplicated code on tests for making them more explicit as they document the step by step process for each use case
- Two migrated Asset Trap test failing due to current state of runtimes, will open in a new issue as it is not relevant to emulator integration
stiiifff
approved these changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @metricaez ! LGTM !
metricaez
added a commit
that referenced
this pull request
Nov 21, 2023
This reverts commit e51c1fe.
stiiifff
pushed a commit
that referenced
this pull request
Nov 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.