Log debug message for JSON-RPC response #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be logged by |
niklasad1
approved these changes
Jan 28, 2022
Oh I didn't know that Anyway maybe we can do a follow up which converts messages here to |
dvdplm
approved these changes
Jan 28, 2022
0623forbidden
pushed a commit
to DEIPworld/substrate-subxt
that referenced
this pull request
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While troubleshooting #399, I wanted to look at the raw bytes returned from the storage query before attempting to decode. Previously this was logged by
jsonrpsee, but no longer.This is useful since we can just ask users to enable
RUST_LOG=debugfor their client/test and we can then easily check the decoding of the raw bytes..