This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Bound elections-phragmen pallet #12549
Draft
Szegoo
wants to merge
48
commits into
paritytech:master
Choose a base branch
from
Szegoo:bound-phragmen
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
69a8b37
Bound Phragmen
Szegoo 5ccfd97
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 82e9f07
fixes
Szegoo 03148fe
passing tests
Szegoo 807bd58
Merge branch 'paritytech:master' into bound-phragmen
Szegoo f61ea32
map_err
Szegoo f6ec1e7
define bounds in runtime
Szegoo eae55fa
fix CI
Szegoo 5e65bfa
fix
Szegoo a201e5a
..
Szegoo 619a707
update benchmarks
Szegoo 09d7596
Merge branch 'paritytech:master' into bound-phragmen
Szegoo c2b71d8
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 0589f64
fixes
Szegoo 38d1c01
error messages updated
Szegoo e162a6f
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 872c176
Update frame/elections-phragmen/src/lib.rs
Szegoo c157249
fix
Szegoo f06dc4c
remove TypeInfo
Szegoo 2960402
update
Szegoo 1afa5b3
fix
Szegoo bc93503
handle error
Szegoo b5ee15d
fix logic
Szegoo 0b2c12e
make clippy happy
Szegoo e737539
nit fix
Szegoo 6f3f2ee
remove redundent checks
Szegoo 962b317
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 04c5a82
fix
Szegoo 076671a
Update frame/elections-phragmen/src/lib.rs
Szegoo 0ad62c1
Update frame/elections-phragmen/src/lib.rs
Szegoo ff0281f
migration
Szegoo 359cac1
complete migrations
Szegoo 68d3cbc
change copyright year
Szegoo 7f93a12
error handling
Szegoo d6b0c69
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 21fa0dc
try-runtime
Szegoo f2aebeb
remove warning
Szegoo fd58b5a
testing migrations
Szegoo 7f39aec
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 7f78052
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 04d0451
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 70e7821
Merge branch 'master' into bound-phragmen
Szegoo 1690a00
pallet & migration builds; tests don't
Szegoo e13bb41
update extrinsic votes arg
Szegoo 839f85d
safer approach
Szegoo 911db04
Merge branch 'paritytech:master' into bound-phragmen
Szegoo 10be77e
Merge branch 'paritytech:master' into bound-phragmen
Szegoo a844619
Merge branch 'master' into bound-phragmen
Szegoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why we subtract one here is very simple actually. It is because we submit
1..T::MaxCandidates::get()
before executing_(RawOrigin::Signed(candidate_account.clone()), candidate_count::<T>())
where we also submit a candidacy. So we cannot have more thanT::MaxCandidates::get()
candidates so that is why we subtract one. @gpestana