-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebRTC client & server #2135
WebRTC client & server #2135
Conversation
and set offer / answer stubs
This comment was marked as outdated.
This comment was marked as outdated.
No, https://datatracker.ietf.org/doc/html/rfc8445#section-2.2
I would prefer to disable DTLS client verification.
I'm not sure that's the right approach. If I'm not mistaken, the server doesn't need to manipulate SDP at all, unless it makes it easier to interact with the API of the |
also add a=ice-options:ice2 to offerer SD
trying to figure out how to do it right now. It's possible in Go library, but not in webrtc-rs, which suggest we might need to tweak it.
Yes for the most part. I was talking about modifying some fields like IP (of the offerer, ie. client) and media's timestamp |
also - remove negotiated flag in createDataChannel - add ice-lite attr - active setup
which indicates that there will be no further candidates
- `end-of-candidates` requires a=ice-options:trickle - BUNDLE is not needed, although mid is
The certificate in `./static` directory **MUST** be marked as trusted (Chrome: | ||
'Security and privacy' -> 'Security' -> 'Manage certificates'). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can discard that. It turned out to be another issue with the library I'm using.
Closing. The work will be continued in libp2p/rust-libp2p#2622 |
Previous work by @tomaka: #1938
Refs #1712
TODO:
webrtc
rs librarytls-id
attribute? no. it's because of the issue with local candidates (see https://github.com/melekes/libp2p-webrtc-direct/blob/ed829dc035b7cff1c155bfbd402261fbadf86d72/src/transport.rs#L531-L540)