-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release CI #97
Draft
AndWeHaveAPlan
wants to merge
8
commits into
main
Choose a base branch
from
release-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release CI #97
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d5b9c48
gha test
AndWeHaveAPlan 7bf9d49
stop build for tests
AndWeHaveAPlan a293264
docker context
AndWeHaveAPlan 76f815f
-f
AndWeHaveAPlan fdc44db
checkout
AndWeHaveAPlan 33d589e
COPY build-llvm.sh
AndWeHaveAPlan 36f9345
Update .github/Dockerfile-llvm
alvicsam 199b614
try parity runner
alvicsam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
FROM revive-llvm | ||
|
||
WORKDIR /app | ||
|
||
COPY . . | ||
RUN RUSTFLAGS='-L /app/llvm18.0/lib/unknown -L /usr/lib -L /app/llvm18.0/lib' REVIVE_INSTALL_DIR='/app/release/revive/' make install-revive |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
FROM alpine:3.20.3 | ||
|
||
ARG RUST_VERSION=stable | ||
|
||
RUN apk add bash git cmake make ninja python3 ncurses-static curl | ||
RUN ninja --version | ||
|
||
COPY build-llvm.sh . | ||
|
||
RUN bash -c ./build-llvm.sh | ||
|
||
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain ${RUST_VERSION} | ||
ENV PATH=/root/.cargo/bin:/llvm18.0/bin:${PATH} | ||
|
||
WORKDIR /app | ||
RUN REVIVE_INSTALL_DIR=$(pwd)/target/release |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
name: Release | ||
run-name: Release ${{ github.ref_name }} | ||
on: | ||
push: | ||
tags: | ||
- "[0-9]+.[0-9]+.[0-9]+" | ||
- "[0-9]+.[0-9]+.[0-9]+-[a-zA-Z0-9]+" | ||
jobs: | ||
|
||
CreateRelease: | ||
permissions: | ||
contents: write | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- name: Release | ||
uses: softprops/action-gh-release@v2 | ||
with: | ||
draft: true | ||
make_latest: true | ||
|
||
Release: | ||
needs: [CreateRelease] | ||
permissions: | ||
contents: write | ||
runs-on: ubuntu-20.04 | ||
env: | ||
GH_TOKEN: ${{ github.token }} | ||
steps: | ||
- name: build llvm | ||
run: docker build -t revive-llvm:latest --progress=plain -f --build-arg RUST_VERSION=1.80 .github/Dockerfile-llvm | ||
|
||
- name: build revive | ||
run: docker build -t revive:latest --progress=plain -f .github/Dockerfile | ||
|
||
- name: get binary | ||
run: docker run --rm revive:latest -v output:/app/output cp /app/release/revive/resolc /app/output | ||
|
||
# docker push revive:latest | ||
|
||
- run: gh release upload ${{ github.ref_name }} output/resolc --clobber |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
name: Test | ||
run-name: Test ${{ github.ref_name }} | ||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened, ready_for_review] | ||
|
||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
Release: | ||
# runs-on: ubuntu-20.04 | ||
runs-on: parity-large | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
|
||
- name: build llvm | ||
run: docker build -t revive-llvm:latest --progress=plain --build-arg RUST_VERSION=1.80 -f .github/Dockerfile-llvm . | ||
|
||
- name: build revive | ||
run: docker build -t revive:latest --progress=plain -f .github/Dockerfile | ||
|
||
- name: get binary | ||
run: docker run --rm revive:latest -v output:/app/output cp /app/release/revive/resolc /app/output . | ||
|
||
# docker push revive:latest | ||
|
||
- run: gh release upload ${{ github.ref_name }} output/resolc |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to modify the
build-llvm.sh
file to use other flags. AFAIK @xermicus discovered that some other flags are needed to it statically links against LLVMslibc++
instead of gccslibstdc++
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, when I tried cross compiling to musl using the current build script, resolc was still dyn linked against
libstdc++
(and segfaulted with an LLVM panic message). See also this comment in the related issue.@wpt967 mentioned he was looking into it, what is the status?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I told @wpt967 to de-pritotize this one since we are only supporting compilation REMIX for now. Until we have proper releases.