xcm: avoid subtracting delivery fees twice #7201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --audience runtime_dev --bump patch |
|
Sorry, only members of the organization paritytech members can run commands. |
carlosala
force-pushed
the
fix/reserve-jit-withdraw
branch
from
12daf63 to
8ed291c
Compare
franciscoaguirre
approved these changes
Jan 16, 2025
|
@carlosala could we maybe get some test for this? :D (Not sure how the test infrastructure looks right now) |
|
I'm not really sure either, what do you think @franciscoaguirre? |
acatangiu
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
AFAIK there is no test verifying the right delivery fee being charged - aka there are tests verifying fees are charged but not asserting on amounts.
But there are already many tests verifying that DepositReserveAsset is working under various conditions, so any breakage would be caught. CI should be green for this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the delivery fees are being subtracted twice if the
jit_withdrawmode is enabled, resulting in assets being trapped. This is an example of it.This does not happen in 2412 anymore after #4834.