Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating pallet-xcm-benchmarks to V2 #6618

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Krayt78
Copy link

@Krayt78 Krayt78 commented Nov 22, 2024

Description

Migrated pallet-xcm-benchmarks to benchmaking syntax V2
This is part of #6202

@Krayt78 Krayt78 requested a review from a team as a code owner November 22, 2024 22:46
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my review could def be more in depth, but i scrolled through the PR, and everything looks sensible.

@re-gius re-gius added R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 27, 2024
Copy link

Review required! Latest push from author must always be reviewed

@clangenb
Copy link
Contributor

Hmm, there was already an open PR for that: #6395

Please double-check if there is already PR for these things, and please review them fast, so that these mishaps don't occur.

@Krayt78
Copy link
Author

Krayt78 commented Nov 28, 2024

Hmm, there was already an open PR for that: #6395

Please double-check if there is already PR for these things, and please review them fast, so that these mishaps don't occur.

Sorry my bad didnt see this one, i thought you had only done the non generic one :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants