-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating pallet-xcm-benchmarks to V2 #6618
base: master
Are you sure you want to change the base?
Migrating pallet-xcm-benchmarks to V2 #6618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my review could def be more in depth, but i scrolled through the PR, and everything looks sensible.
Review required! Latest push from author must always be reviewed |
Hmm, there was already an open PR for that: #6395 Please double-check if there is already PR for these things, and please review them fast, so that these mishaps don't occur. |
Sorry my bad didnt see this one, i thought you had only done the non generic one :/ |
Description
Migrated pallet-xcm-benchmarks to benchmaking syntax V2
This is part of #6202