Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: manager: Improve address handling and refactor PeerState #248

Closed
wants to merge 66 commits into from
Closed

WIP: manager: Improve address handling and refactor PeerState #248

wants to merge 66 commits into from

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Sep 20, 2024

No description provided.

lexnv added 30 commits September 17, 2024 19:37
@lexnv
manager/address: Fix typo
22d6b48 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/address: Store addresses using a HashMap
86e017f 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Keep dial addresses around even if the peer is connected
8ec9e54 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Update dial failure address scores
83b9361 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Clean up the disconnected dial record on failure
b28a234 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Bump addresses to 64
68e3328 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Make add_known_address more robust to track multiple peer addrs
4ad526f 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Construct the store with dialing address present
a924fa2 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Track dial failure addresses regardless of peer states
445ca74 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Update addresses only in dedicated function
7220f7a 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Remove unneeded methods
f56e8c0 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Keep track of the latest connection ID
a0fb0c9 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Better constants for scoring
40e149b 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Update addresses on connection established
7e15747 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Replace AddressRecord with DialRecord
9ce8a20 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Remove AddressRecord from the Opening state
47f97b5 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Remove assert
7f3147d 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Rename DialRecord to ConnectionRecord
d6e2d4d 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/address: Remove connection ID from address store
1eda8a7 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/types: Add wrappers for consturcting connection records
526244b 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/address: Implement eviction algorithm
dcac138 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Rename recrod to address record
fc35762 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/handle: Keep WriteLock for a shorter time
250c289 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/peer_state: Implement on_dial state advancing
6da7acf 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Type safe state transition and trransports more modular
b26dbd1 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/peer_state: Implement on_dial_failure state advancing
90e5b45 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/peer_state: Merge secondary connection with PeerState
5cd7949 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/peer_state: Handle connection closed transition
3804db4 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/peer_state: Adjust connection established return
6912dda 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manger: Use new peer state
900ff49 
Signed-off-by: Alexandru Vasile <[email protected]>
lexnv added 26 commits September 20, 2024 17:40
@lexnv
manager: Keep connection record on secondary upgrades
1eea678 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Handle dial initiation result friendlier
b684142 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Simplify dial on single and multiaddresses
461eb65 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/handle: Use state transitions
a1dfe2e 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/peer_state: Add documentation
6d455d0 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Document possible race
808793c 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager/peer_state: Ensure disconnects are reported properly
dc6073d 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
transport/tests: Connections are reported properly now
0c36972 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
transport/manager: Move error to score to the address store
ecff792 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
transport/maanager: Update address score on open failure
8a95ba8 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state: Move open failure transitions to dedicated module
cd8ffb1 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
transport/manager: Move to dedicated module
bda30df 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check can dial states
b2c51db 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check disconnected -> dialing
a6d8684 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check Disconnected -> Opening
5959e4e 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check on dial failure
6a613d8 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check connection established
966cd18 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check connection established for Dialing
6751581 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check connection closed
fc9a848 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check open failure state
fa03738 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check full lifecycle of a connection
dd3714f 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Remove pending connection state after success
6050e96 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state: Handle connection opening
1555437 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state/tests: Check opening of connections
3c8058e 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
manager: Better tracking of addresses for opening
de5354b 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
peer_state: Return bool when dial failure was handled
9869283 
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv mentioned this pull request Sep 24, 2024
Merged
@lexnv
Copy link
Collaborator Author

lexnv commented Oct 2, 2024

This PR was refactored to make the review process a bit more friendly:

@lexnv lexnv closed this Oct 2, 2024
lexnv added a commit that referenced this pull request Oct 25, 2024
@lexnv @dmitry-markin
address_store: Improve address tracking and add eviction algorithm (#250
2ef3751 
)

This PR improves the transport manager's address tracking to keep a
healthier view of addresses.

General changes:
- Fixes a bug where `listener` addresses were tracked instead of
`dialing` addresses (incoming connections may be established with
ephemeral ports and there's no guarantee the remote is listening on
them)
- `PeerIdMismatch` error coming from the noise handshake redirects the
address to the appropriate peer for healthier addresses
- Addresses are tracked first, regardless of the peer state to ensure we
update our view of the addresses (reachable or not)

Address Store changes:
- The store is bounded to a maximum of 64 tracked addresses
- Removing and reinsertion of addresses into the store is prone to error
and instead the address store updates addresses in place
- Introduces an eviction algorithm for tracking addresses with higher
score

### Testing Done
- added extra tests to the address store
- tested with subp2p-explorer for discovering kusama


This PR is part of a bigger refactor to keep track of healthier
addresses.
It is essentially a breakdown of
#248 for an easier review
process.

---------

Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Dmitry Markin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lexnv