Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement transfer all #434

Merged
merged 4 commits into from
Sep 23, 2024
Merged

feat: implement transfer all #434

merged 4 commits into from
Sep 23, 2024

Conversation

marshacb
Copy link
Contributor

@marshacb marshacb commented Sep 21, 2024 •
edited
Loading

Description

This PR adds support for the transferAll extrinsic

Changes

  • adds a transferAll option to the TransferArgsOpts
  • Adds the transferAll extrinsic for the assets, balances, foreignAssets, poolAssets and orml tokens pallets
  • Adds unit and integration tests for transferAll extrinsic

closes: #429

@marshacb marshacb requested review from TarikGul and bee344 September 21, 2024 03:29
TarikGul
TarikGul reviewed Sep 22, 2024
View reviewed changes
src/AssetTransferApi.ts Outdated Show resolved Hide resolved
TarikGul
TarikGul approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit. LGTM

IkerAlus
IkerAlus reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a nitpick, the Readme.md should be updated to show the new transferAll option in the TransferArgsOpts section.

@marshacb
remove commented code
624c593 
add transferAll option to readme
@marshacb marshacb merged commit 811eba8 into main Sep 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarikGul TarikGul TarikGul approved these changes

@IkerAlus IkerAlus IkerAlus approved these changes

@bee344 bee344 Awaiting requested review from bee344

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "transfer all" calls from Asset Pallet for local transfers
3 participants
@marshacb @IkerAlus @TarikGul