-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support relay to bridge tx construction #409
Merged
marshacb
merged 48 commits into
main
from
cameron-support-relay-to-bridge-tx-construction
Jun 12, 2024
Merged
feat: support relay to bridge tx construction #409
marshacb
merged 48 commits into
main
from
cameron-support-relay-to-bridge-tx-construction
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add unit tests add util functions for determining direction based on asset and dest locations
…ocations add SystemToBridge integration tests
updated getGlobalConsensusSystemName to check X1 junction rather than entire string for valid consensus name added consensus name check to xcm tx input checks for system to bridge direction
add AssetTransferType and resolveTransferType util func
add util function for constructing beneficiary add util to construct versioned xcm asset id add ability to explicitly construct transferAssetsUsingTypeAndThen by providing transferAssetsType
update resolveCall to use assetTransferType
update resolveAssetTransferType and createXcmVersionedAssetId
update integration tests add unit tests
…s AssetHub locations rather than the relay chains location removed assumption that polkadots location should be intended as polkadot assethub added parseLocationStrToLocation util function updated SystemToBridge tests to explicitly provide AssetHub locations for polkadot kusama bridge cases
remove unused util function
marshacb
changed the title
feat: support relay to bridge tx construction[WIP]
feat: support relay to bridge tx construction
Jun 12, 2024
bee344
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
TarikGul
reviewed
Jun 12, 2024
TarikGul
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, lgmt! Just one nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
RelayToBridge
tx direction for constructing BridgeHub transactions from the Relay Chain.Changes
RelayToBridge
direction.RelayToBridge
directionRelayToBridge
directionBridgeHub P<>K Bridge: (Rococo ROC -> Westend AssetHub)
Example of constructing a
transferAssetsUsingTypeAndThen
call sending ROC to Westend AssetHub from Rococo:Expected output: