Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal): refactor all weight limits to not use createType #310

Merged
merged 2 commits into from
Nov 3, 2023
Merged

fix(internal): refactor all weight limits to not use createType #310

merged 2 commits into from
Nov 3, 2023

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Nov 2, 2023 •
edited
Loading

Summary

  • Refactor all createWeightLimit calls to be return XcmWeight types instead of Polkadot-js weight types.
  • Refactor all createFeeAssetItem calls to return a number type instead of a u32 polkadot-js type.

rel: #301

@TarikGul TarikGul changed the title fix(internal): refactor all weight limits to not use createType [WIP] fix(internal): refactor all weight limits to not use createType Nov 2, 2023
marshacb
marshacb approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TarikGul TarikGul merged commit fed52d9 into main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshacb marshacb marshacb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TarikGul @marshacb