Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal): refactor dest and beneficiary types generators #303

Merged
merged 11 commits into from
Oct 20, 2023
Merged

fix(internal): refactor dest and beneficiary types generators #303

merged 11 commits into from
Oct 20, 2023

Conversation

TarikGul
Copy link
Member

rel: #301

part 1.

This ensures we don't rely on createType for type generation, and focuses first on refactoring destination and beneficiary type generators to ensure PR's stay small.

@TarikGul TarikGul requested a review from marshacb October 20, 2023 18:37
bee344
bee344 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@TarikGul TarikGul merged commit 8aa68b7 into main Oct 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bee344 bee344 bee344 approved these changes

@marshacb marshacb Awaiting requested review from marshacb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TarikGul @bee344