Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update readme, and add use case examples #285

Merged
merged 8 commits into from
Sep 18, 2023
Merged

docs: update readme, and add use case examples #285

merged 8 commits into from
Sep 18, 2023

Conversation

TarikGul
Copy link
Member

Summary

  • Show how to run the examples
  • Add docs on foreign Assets
  • Add docs on liquid pool transfers
  • Add docs on transfers for polkadotXcm and xTokens
  • Add comments to BaseErrorEnum

@TarikGul TarikGul requested a review from IkerAlus September 18, 2023 14:15
IkerAlus
IkerAlus requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just some suggestions from my side.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@IkerAlus IkerAlus self-requested a review September 18, 2023 15:05
IkerAlus
IkerAlus approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@IkerAlus IkerAlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TarikGul TarikGul merged commit 780dfdf into main Sep 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IkerAlus IkerAlus IkerAlus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TarikGul @IkerAlus