Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove remaining use of parseInt #276

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix: remove remaining use of parseInt #276

merged 2 commits into from
Sep 13, 2023

Conversation

TarikGul
Copy link
Member

This removes all the remaining instances of parseInt. It also chains the input of isSystemChain to only take in strings for chainId.

@TarikGul TarikGul requested a review from marshacb September 13, 2023 13:05
marshacb
marshacb approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice changes! LGTM!

@TarikGul TarikGul merged commit 253c570 into main Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marshacb marshacb marshacb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TarikGul @marshacb