resolve @typescript-eslint/no-unsafe-enum-comparison

paritytech · Nov 29, 2023 · c92a2f4 · c92a2f4
1 parent 10fdf17
commit c92a2f4
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 7 deletions.
diff --git a/src/AssetTransferApi.ts b/src/AssetTransferApi.ts
@@ -38,6 +38,7 @@ import {
 	checkLocalTxInput,
 	checkXcmTxInputs,
 	checkXcmVersion,
+	LocalTxType,
 } from './errors';
 import { Registry } from './registry';
 import { ChainInfoRegistry } from './registry/types';
@@ -240,19 +241,19 @@ export class AssetTransferApi {
 				let tx: SubmittableExtrinsic<'promise', ISubmittableResult>;
 				let palletMethod: LocalTransferTypes;
 
-				if (localAssetType === 'Balances') {
+				if (localAssetType === LocalTxType.Balances) {
 					tx =
 						method === 'transferKeepAlive'
 							? balances.transferKeepAlive(_api, addr, amount)
 							: balances.transfer(_api, addr, amount);
 					palletMethod = `balances::${method}`;
-				} else if (localAssetType === 'Assets') {
+				} else if (localAssetType === LocalTxType.Assets) {
 					tx =
 						method === 'transferKeepAlive'
 							? assets.transferKeepAlive(_api, addr, assetId, amount)
 							: assets.transfer(_api, addr, assetId, amount);
 					palletMethod = `assets::${method}`;
-				} else if (localAssetType === 'PoolAssets') {
+				} else if (localAssetType === LocalTxType.PoolAssets) {
 					tx =
 						method === 'transferKeepAlive'
 							? poolAssets.transferKeepAlive(_api, addr, assetId, amount)

diff --git a/src/createXcmCalls/util/establishXcmPallet.ts b/src/createXcmCalls/util/establishXcmPallet.ts
@@ -60,7 +60,7 @@ export const establishXcmPallet = (
  */
 const isXTokensOriginNonForeignAssetsPalletTx = (
 	xPallet?: XcmPalletName,
-	direction?: Direction | string,
+	direction?: Direction,
 	isForeignAssetsTransfer?: boolean,
 	isParachainPrimaryNativeAsset?: boolean,
 ): boolean => {

diff --git a/src/errors/checkLocalTxInputs.ts b/src/errors/checkLocalTxInputs.ts
@@ -9,7 +9,7 @@ import { checkLiquidTokenValidity } from '../errors/checkXcmTxInputs';
 import { Registry } from '../registry';
 import { BaseError, BaseErrorsEnum } from './BaseError';
 
-enum LocalTxType {
+export enum LocalTxType {
 	Assets = 'Assets',
 	Balances = 'Balances',
 	ForeignAssets = 'ForeignAssets',

diff --git a/src/errors/checkXcmTxInputs.ts b/src/errors/checkXcmTxInputs.ts
@@ -948,7 +948,7 @@ export const checkXcmVersionIsValidForPaysWithFeeDest = (
  * @param isLiquidTokenTransfer
  */
 export const checkLiquidTokenTransferDirectionValidity = (xcmDirection: Direction, isLiquidTokenTransfer: boolean) => {
-	if (xcmDirection !== 'SystemToPara' && isLiquidTokenTransfer) {
+	if (xcmDirection !== Direction.SystemToPara && isLiquidTokenTransfer) {
 		throw new BaseError(
 			`isLiquidTokenTransfer may not be true for the xcmDirection: ${xcmDirection}.`,
 			BaseErrorsEnum.InvalidInput,

diff --git a/src/errors/index.ts b/src/errors/index.ts
@@ -3,6 +3,6 @@
 export { BaseError, BaseErrorsEnum } from './BaseError';
 export { checkBaseInputOptions } from './checkBaseInputOptions';
 export { checkBaseInputTypes } from './checkBaseInputTypes';
-export { checkLocalTxInput } from './checkLocalTxInputs';
+export { checkLocalTxInput, LocalTxType } from './checkLocalTxInputs';
 export { checkXcmTxInputs } from './checkXcmTxInputs';
 export { checkXcmVersion } from './checkXcmVersion';