fix: add Ethereum address check in createBeneficiary for ParaToPara d…

…irection (#315)
paritytech · Nov 6, 2023 · 2cb2d13 · 2cb2d13
1 parent 6fbd6c4
commit 2cb2d13
Show file tree

Hide file tree

Showing 2 changed files with 46 additions and 2 deletions.
diff --git a/src/createXcmTypes/ParaToPara.spec.ts b/src/createXcmTypes/ParaToPara.spec.ts
@@ -29,6 +29,25 @@ describe('ParaToPara', () => {
 
 			expect(beneficiary).toStrictEqual(expectedRes);
 		});
+		it('Should work for V2 for an Ethereum Address', () => {
+			const beneficiary = ParaToPara.createBeneficiary('0x96Bd611EbE3Af39544104e26764F4939924F6Ece', 2);
+
+			const expectedRes = {
+				V2: {
+					parents: 0,
+					interior: {
+						X1: {
+							AccountKey20: {
+								key: '0x96Bd611EbE3Af39544104e26764F4939924F6Ece',
+								network: 'Any',
+							},
+						},
+					},
+				},
+			};
+
+			expect(beneficiary).toStrictEqual(expectedRes);
+		});
 		it('Should work for V3', () => {
 			const beneficiary = ParaToPara.createBeneficiary(
 				'0xf5d5714c084c112843aca74f8c498da06cc5a2d63153b825189baa51043b1f0b',
@@ -48,6 +67,24 @@ describe('ParaToPara', () => {
 				},
 			};
 
+			expect(beneficiary).toStrictEqual(expectedRes);
+		});
+		it('Should work for V3 for an Ethereum Address', () => {
+			const beneficiary = ParaToPara.createBeneficiary('0x96Bd611EbE3Af39544104e26764F4939924F6Ece', 3);
+
+			const expectedRes = {
+				V3: {
+					parents: 0,
+					interior: {
+						X1: {
+							AccountKey20: {
+								key: '0x96Bd611EbE3Af39544104e26764F4939924F6Ece',
+							},
+						},
+					},
+				},
+			};
+
 			expect(beneficiary).toStrictEqual(expectedRes);
 		});
 	});

diff --git a/src/createXcmTypes/ParaToPara.ts b/src/createXcmTypes/ParaToPara.ts
@@ -2,6 +2,7 @@
 
 import type { ApiPromise } from '@polkadot/api';
 import type { AnyJson } from '@polkadot/types/types';
+import { isEthereumAddress } from '@polkadot/util-crypto';
 
 import { BaseError, BaseErrorsEnum } from '../errors';
 import { Registry } from '../registry';
@@ -44,21 +45,27 @@ export const ParaToPara: ICreateXcmType = {
 	 */
 	createBeneficiary: (accountId: string, xcmVersion?: number): XcmDestBenificiary => {
 		if (xcmVersion == 2) {
+			const X1 = isEthereumAddress(accountId)
+				? { AccountKey20: { network: 'Any', key: accountId } }
+				: { AccountId32: { network: 'Any', id: accountId } };
+
 			return {
 				V2: {
 					parents: 0,
 					interior: {
-						X1: { AccountId32: { network: 'Any', id: accountId } },
+						X1,
 					},
 				},
 			};
 		}
 
+		const X1 = isEthereumAddress(accountId) ? { AccountKey20: { key: accountId } } : { AccountId32: { id: accountId } };
+
 		return {
 			V3: {
 				parents: 0,
 				interior: {
-					X1: { AccountId32: { id: accountId } },
+					X1,
 				},
 			},
 		};