Fixes list count drifting over time #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the list count has a fundamental flaw in that its not decrementing the total whenever a user is removed from a list so over time it just continues to drift upward.
This completely removes partial counting from the list totals equation and instead relies on redis key incrementing and decrementing to keep track of totals and then periodically pulls those values into the database. This removes the counting load almost completely from the database.
It also fixes re-counting when updating a ruleset for a list.
This does temporarily reset the count of every list to zero so that they can be recalculated accurate to start the new incrementing system.