Align ek abstraction with TCG EK Credential profile #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thore Sommer <[email protected]>
THS-on
force-pushed
the
fix-ecc-ek-abstraction
branch
from
04e6225 to
40c623f
Compare
Signed-off-by: Thore Sommer <[email protected]>
…finitionObject Signed-off-by: Thore Sommer <[email protected]>
THS-on
force-pushed
the
fix-ecc-ek-abstraction
branch
from
40c623f to
a119e8c
Compare
|
What is currently missing is reading the template and potential nonce from NV. Do we need that feature? Edit: should be possible to implement this via key customization, so not implementing this directly in this PR. |
THS-on
force-pushed
the
fix-ecc-ek-abstraction
branch
2 times, most recently
from
cb7e1dc to
0da45ee
Compare
Signed-off-by: Thore Sommer <[email protected]>
THS-on
force-pushed
the
fix-ecc-ek-abstraction
branch
from
0da45ee to
80f3326
Compare
Signed-off-by: Thore Sommer <[email protected]>
THS-on
force-pushed
the
fix-ecc-ek-abstraction
branch
from
80f3326 to
2176c29
Compare
This was referenced Oct 21, 2024
ionut-arm
approved these changes
Oct 30, 2024
| @@ -42,12 +66,19 @@ pub fn create_ek_public_from_default_template<IKC: IntoKeyCustomization>( | |||
| ) -> Result<Public> { | |||
| let key_customization = key_customization.into_key_customization(); | |||
|
|
|||
| // user_with_auth is not set for the lower profiles (RSA 20248 and ECC P256) | |||
There was a problem hiding this comment.
Nit:
Suggested change
| // user_with_auth is not set for the lower profiles (RSA 20248 and ECC P256) | |
| // user_with_auth is not set for the lower profiles (RSA 2048 and ECC P256) |
|
Nevermind, saw the comment in #546 |
Superhepper
added a commit
to Superhepper/rust-tss-esapi
that referenced
this pull request
Nov 7, 2024
This takes the following PRs and from the main branch and adapts them so that they can be merged into the 7.x.y branch: \parallaxsecond#464 (By Ionut Mihalcea <[email protected]>) \parallaxsecond#414 (By Thore Sommer <[email protected]>) \parallaxsecond#552 (By Thore Sommer <[email protected]>) Co-authored-by: Jesper Brynolf <[email protected]> Co-authored-by: Thore Sommer <[email protected]> Co-authored-by: Ionut Mihalcea <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The used hashing and symmetric algorithm and authPolicy are different based on the key size/curve.
While the old generated EKs still work, they are not that useful as they don't match the EK found in provisioned EK certificates according to the TCG EK Credential profile. This fixes that.