-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency Update #544
Dependency Update #544
Conversation
b34fd23
to
4657c40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing stuff, thanks for the patch, I'm in favour of these changes!
What's missing? Why is it a draft?
I wanted peoples input before making it a real PR. |
4b8c518
to
12c8217
Compare
Updates all the dependencies of the crate in order to be able to use newer versions of rust and and remove old lints and checks. - Updates Rust edition to 2021 - Updates MSRV to 1.74.0 - Updates crate dependencies. - Updates lock file. - Updates minimum supported tpm2-tss version to 4.0.1. - Updates the Fedora version the CI test image is based on to 37. Co-authored-by: Ionut Mihalcea <[email protected]> Co-authored-by: Travis Finkenauer <[email protected]> Co-authored-by: William Brown <[email protected]> Signed-off-by: Jesper Brynolf <[email protected]>
12c8217
to
8533d67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a lot of changes. Looks good, thanks! 👍
By the way I've edited this PR description to add "fixes" and "closes". See if this accurate (I like it when the issues/PRs are cross-linked). 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment
@@ -48,7 +48,7 @@ cross-compile-openssl() { | |||
cross-compile-tpm2-tss() { | |||
pushd /tmp/tpm2-tss | |||
[ ! -f configure ] && ./bootstrap | |||
./configure --enable-fapi=no --prefix=/ --build=x86_64-pc-linux-gnu --host=$1 --target=$1 CC=$1-gcc | |||
./configure --disable-fapi --disable-policy --prefix=/ --build=x86_64-pc-linux-gnu --host=$1 --target=$1 CC=$1-gcc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I kinda hope this doesn't disable policies for ESAPI as well... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to look deep in their config files to exact what the flag did but got lost in how much I do not ... approve .. of autoconf files and syntax. But I saw that the Yocto project made some similar changes in a patch I looked at for moving to 4.0.1.
Updates all the dependencies of the crate in order to be able to use newer versions of rust and and
remove old lints and checks.
Fixes #516
Closes #540