Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Update #544

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

Superhepper
Copy link
Collaborator

@Superhepper Superhepper commented Sep 9, 2024

Updates all the dependencies of the crate in order to be able to use newer versions of rust and and
remove old lints and checks.

  • Updates Rust edition to 2021
  • Updates MSRV to 1.74.0
  • Updates crate dependencies.
  • Updates lock file.
  • Updates minimum supported tpm2-tss version to 4.0.1.

Fixes #516
Closes #540

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff, thanks for the patch, I'm in favour of these changes!

What's missing? Why is it a draft?

tss-esapi-sys/README.md Show resolved Hide resolved
@Superhepper
Copy link
Collaborator Author

Amazing stuff, thanks for the patch, I'm in favour of these changes!

What's missing? Why is it a draft?

I wanted peoples input before making it a real PR.

@Superhepper Superhepper force-pushed the rust-2021-edition branch 15 times, most recently from 4b8c518 to 12c8217 Compare September 20, 2024 20:26
Updates all the dependencies of the crate in order
to be able to use newer versions of rust and and
remove old lints and checks.

- Updates Rust edition to 2021
- Updates MSRV to 1.74.0
- Updates crate dependencies.
- Updates lock file.
- Updates minimum supported tpm2-tss version
  to 4.0.1.
- Updates the Fedora version the CI test image
  is based on to 37.

Co-authored-by: Ionut Mihalcea <[email protected]>
Co-authored-by: Travis Finkenauer <[email protected]>
Co-authored-by: William Brown <[email protected]>
Signed-off-by: Jesper Brynolf <[email protected]>
@Superhepper Superhepper marked this pull request as ready for review September 20, 2024 20:50
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a lot of changes. Looks good, thanks! 👍

tss-esapi/tests/Dockerfile-ubuntu Show resolved Hide resolved
@wiktor-k
Copy link
Collaborator

By the way I've edited this PR description to add "fixes" and "closes". See if this accurate (I like it when the issues/PRs are cross-linked). 👋

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment

@@ -48,7 +48,7 @@ cross-compile-openssl() {
cross-compile-tpm2-tss() {
pushd /tmp/tpm2-tss
[ ! -f configure ] && ./bootstrap
./configure --enable-fapi=no --prefix=/ --build=x86_64-pc-linux-gnu --host=$1 --target=$1 CC=$1-gcc
./configure --disable-fapi --disable-policy --prefix=/ --build=x86_64-pc-linux-gnu --host=$1 --target=$1 CC=$1-gcc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I kinda hope this doesn't disable policies for ESAPI as well... 🤔

Copy link
Collaborator Author

@Superhepper Superhepper Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to look deep in their config files to exact what the flag did but got lost in how much I do not ... approve .. of autoconf files and syntax. But I saw that the Yocto project made some similar changes in a patch I looked at for moving to 4.0.1.

@Superhepper Superhepper merged commit 97ccc11 into parallaxsecond:main Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Rust edition.
3 participants