Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some context log message levels. #454

Merged

Conversation

Firstyear
Copy link
Contributor

Reduce some messages from info to debug that should not be displayed by default to all users of the library.

ionut-arm
ionut-arm previously approved these changes Oct 16, 2023
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the change, it does make more sense to have them as debug logs. But I think you need to fix the imports in this file to reflect your changes.

Reduce some messages from info to debug that should not be displayed
by default to all users of the library.

Signed-off-by: William Brown <[email protected]>
@Firstyear
Copy link
Contributor Author

Sorry about that! Fixed up now.

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ionut-arm ionut-arm merged commit a3765db into parallaxsecond:main Oct 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants