Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate credential #558

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Activate credential #558

merged 3 commits into from
Nov 23, 2021

Conversation

ionut-arm
Copy link
Member

Part of #539

This commit adds key attestation using the ActivateCredential mechanism
in the TPM provider. The following bits are being added:

* routing of the new PrepareKeyAttestation and AttestKey operations
through the service
* handling of the mentioned operations in the TPM provider for the
ActivateCredential mechanism in particular; only the case when no
attesting key is given is currently supported
* a new config field for the TPM provider which allows the admin to
specify the Endorsement hierarchy auth, which is used when attesting
keys using the default root Endorsement Key
* a new test is added to prepare an attestation (using a software TPM to
generate the credential and encrypted secret) and perform the
attestation; all the steps have also been added to the CI script to
configure Endorsement Hierarchy protection and to prepare a 2nd software
TPM for use in MakeCredential

Signed-off-by: Ionut Mihalcea <[email protected]>
@ionut-arm ionut-arm added the enhancement New feature or request label Nov 16, 2021
@ionut-arm ionut-arm added this to the Parsec Release 0.9.0 milestone Nov 16, 2021
@ionut-arm ionut-arm requested a review from anta5010 November 16, 2021 14:57
@ionut-arm ionut-arm self-assigned this Nov 16, 2021
@ionut-arm ionut-arm marked this pull request as ready for review November 22, 2021 11:20
@ionut-arm ionut-arm requested a review from a team as a code owner November 22, 2021 11:20
Signed-off-by: Ionut Mihalcea <[email protected]>
Copy link
Collaborator

@paulhowardarm paulhowardarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test the PR workflow - not a full code review.

@ionut-arm ionut-arm enabled auto-merge November 23, 2021 15:10
@ionut-arm ionut-arm merged commit b169b11 into parallaxsecond:main Nov 23, 2021
@ionut-arm ionut-arm deleted the activate-cred branch July 22, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants