Skip to content

Commit

Permalink
Renamed glyph-input to match naming pattern.
Browse files Browse the repository at this point in the history
  • Loading branch information
azaslonov committed Dec 16, 2023
1 parent b05609f commit 397f646
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 20 deletions.
12 changes: 3 additions & 9 deletions src/button/ko/buttonEditor.html
Original file line number Diff line number Diff line change
Expand Up @@ -13,21 +13,15 @@
</div>

<div class="form-group">
<label for="hyperlinkSelector" class="form-label">
<label for="hyperlink" class="form-label">
Link to
<button class="btn btn-info" role="tooltip" aria-hidden="true" role="tooltip"
data-bind="tooltip: 'A link to be navigated on click.'"></button>
</label>
<div class="input-group">
<input id="hyperlinkSelector" class="form-control" readonly data-bind="value: hyperlinkTitle" />
<button class="btn input-group-btn" aria-label="Select hyperlink"
data-bind="balloon: { position: 'right', component: { name: 'hyperlink-selector', params: { hyperlink: $component.hyperlink, onChange: $component.onHyperlinkChange } } }">
<i aria-hidden="true" class="paperbits-icon paperbits-link-69-2"></i>
</button>
</div>
<input-hyperlink params="{ id: 'hyperlink', hyperlink: $component.hyperlink, onChange: $component.onHyperlinkChange }"></input-hyperlink>
</div>

<glyph-input params="{ selection: model.iconKey, onChange: onIconSelect }"></glyph-input>
<input-glyph params="{ selection: model.iconKey, onChange: onIconSelect }"></input-glyph>

<div class="form-group">
<label for="displayStyle" class="form-label">
Expand Down
2 changes: 1 addition & 1 deletion src/dismiss-button/ko/dismissButtonEditor.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@
<select id="sizeStyle" class="form-control" data-bind="options: sizeStyles, value: sizeStyle, optionsText: 'displayName', optionsValue: 'key'"></select>
</div> -->

<glyph-input params="{ selection: model.iconKey, onChange: onIconSelect }"></glyph-input>
<input-glyph params="{ selection: model.iconKey, onChange: onIconSelect }"></input-glyph>
10 changes: 2 additions & 8 deletions src/picture/ko/pictureEditor.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,18 +27,12 @@
</div>

<div class="form-group">
<label for="hyperlinkSelector" class="form-label">
<label for="hyperlink" class="form-label">
Link to
<button class="btn btn-info" role="tooltip" aria-hidden="true" role="tooltip"
data-bind="tooltip: 'A link to be navigated on click.'"></button>
</label>
<div class="input-group">
<input id="hyperlinkSelector" class="form-control" readonly data-bind="value: hyperlinkTitle" />
<button class="btn input-group-btn" aria-label="Select hyperlink"
data-bind="balloon: { position: 'right', component: { name: 'hyperlink-selector', params: { hyperlink: $component.hyperlink, onChange: $component.onHyperlinkChange } } }">
<i aria-hidden="true" class="paperbits-icon paperbits-link-69-2"></i>
</button>
</div>
<input-hyperlink params="{ id: 'hyperlink', hyperlink: $component.hyperlink, onChange: $component.onHyperlinkChange }"></input-hyperlink>
</div>
</details>

Expand Down
4 changes: 2 additions & 2 deletions src/workshops/hyperlinks/ko/hyperlinkSelector.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ <h1>Hyperlink</h1>
<!-- ko if: hyperlinkProvider -->

<div class="form-group">
<label for="hyperlink">
<label for="hyperlinkTitle">
Link points to:
</label>
<div class="max-w300 text-overflow">
<b id="hyperlink" data-bind="text: $component.selection, attr: { title: selection }"></b>
<b id="hyperlinkTitle" data-bind="text: $component.selection, attr: { title: selection }"></b>
</div>
</div>
<!-- ko if: hyperlinkProvider().hyperlinkDetailsComponentName -->
Expand Down

0 comments on commit 397f646

Please sign in to comment.