Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use image crate instead of the webp one #245

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Use image crate instead of the webp one #245

merged 1 commit into from
Apr 28, 2022

Conversation

melix99
Copy link
Collaborator

@melix99 melix99 commented Mar 13, 2022

The image crate recently gained the ability to fully decode rgba8 webp files, so let's use that for decoding stickers instead of the webp crate that relies on the libwebp C library.

This is more of a test currently, needs image-rs/image#1685 to be merged first. The PR was merged, let's wait for a new release now. A new version is now available.

@melix99 melix99 marked this pull request as ready for review April 27, 2022 21:28
@melix99 melix99 changed the title WIP: Use image crate instead of the webp one Use image crate instead of the webp one Apr 27, 2022
src/session/content/message_row/sticker.rs Outdated Show resolved Hide resolved
Cargo.lock Outdated Show resolved Hide resolved
The new version of the image crate recently gained the ability to fully
decode rgba8 webp images, so let's use that for decoding stickers
instead of the webp crate that relies on the libwebp C library.
@marhkb marhkb merged commit cdfa00c into main Apr 28, 2022
@marhkb marhkb deleted the remove-webp-dep branch April 28, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants